Require and call destructors on ClassAllocated objects #12676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcfarlen
force-pushed
the
class-alloc-destruct
branch
from
b67c2b7 to
5f9211c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the flag to call the destructor on ClassAllocator objects. ClassAllocator now requires that objects have a noexcept destructor that it can call on all objects. This is much safer than the explicit flag and should not add any overhead for trivially destructed types. I've added unit tests for this and also ran ASAN to make sure that the tests don't report memory leaks.
The unit tests were written by Claude, other code is my own.